Skip to content

[codex] Reduce quick switcher startup work #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdroidian merged 1 commit into from
Jun 30, 2026
Merged

[codex] Reduce quick switcher startup work #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/quickSwitcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,17 +150,21 @@ const initializeQuickSwitcher = ({
}),
});
let isDialogOpen = false;
let hasRenderedDialog = false;

const persistBookmarks = (): void => {
void extensionAPI.settings.set(BOOKMARKS_SETTING_KEY, bookmarks);
};

const closeDialog = (): void => {
isDialogOpen = false;
render();
if (hasRenderedDialog) {
render();
}
};

const render = (): void => {
hasRenderedDialog = true;
ReactDOM.render(
<QuickSwitcherDialog
bookmarks={bookmarks}
Expand Down Expand Up @@ -229,18 +233,18 @@ const initializeQuickSwitcher = ({
.catch(() => undefined);
};

persistBookmarks();
document.addEventListener("keydown", onDocumentKeyDown, true);
registerCommand();
render();

return {
getBookmarks: (): QuickSwitcherBookmark[] => bookmarks,
open: openDialog,
setBookmarks: (nextBookmarks: QuickSwitcherBookmark[]): void => {
bookmarks = sanitizeBookmarks({ bookmarks: nextBookmarks });
persistBookmarks();
render();
if (hasRenderedDialog) {
render();
}
},
unload: (): void => {
closeDialog();
Expand Down
Loading