Skip to content

Allow setnafill() to accept logical vectors in cols (#4113)#7842

Open
venom1204 wants to merge 2 commits into
masterfrom
issue41113
Open

Allow setnafill() to accept logical vectors in cols (#4113)#7842
venom1204 wants to merge 2 commits into
masterfrom
issue41113

Conversation

@venom1204

Copy link
Copy Markdown
Contributor

CLOSES #4113

this PR enables setnafill() to accept logical vectors for the cols argument, allowing for dynamic column selection via conditions like sapply(DT, is.numeric). The implementation updates the internal colnamesInt C utility to handle logical vectors with exact length matching and NA validation while ensuring that existing error-handling logic remains consistent across the package.

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (895067d) to head (e1904e8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7842      +/-   ##
==========================================
- Coverage   99.02%   99.01%   -0.01%     
==========================================
  Files          88       88              
  Lines       17266    17280      +14     
==========================================
+ Hits        17097    17110      +13     
- Misses        169      170       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown
  • HEAD=issue41113 slower P<0.001 for DT[by] max regression fixed in #7480
    Comparison Plot

Generated via commit e1904e8

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 54 seconds
Installing different package versions 24 seconds
Running and plotting the test cases 7 minutes and 13 seconds

@venom1204 venom1204 changed the title UPDATED CHANGES Allow setnafill() to accept logical vectors in cols (#4113) Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setnafill could accept cols=logical(ncol(x))

1 participant