Conversation
venom1204
requested review from
HughParsonage,
MichaelChirico and
ben-schwen
as code owners
July 26, 2026 10:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7841 +/- ##
==========================================
- Coverage 99.02% 99.01% -0.01%
==========================================
Files 88 88
Lines 17266 17280 +14
==========================================
+ Hits 17097 17110 +13
- Misses 169 170 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Generated via commit 1794b75 Download link for the artifact containing the test results: ↓ atime-results.zip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #4113
this pr enables
setnafill()to accept logical vectors for thecolsargument, allowing for dynamic column selection via conditions likesapply(DT,is.numeric). The implementation updates the internalcolnamesInt Cutility to handle logical vectors with exact length matching andNAvalidation while ensuring that existing error-handling logic remains consistent across the package.