Skip to content

add join statistics#7566

Open
ben-schwen wants to merge 13 commits into
masterfrom
merge_statistics
Open

add join statistics#7566
ben-schwen wants to merge 13 commits into
masterfrom
merge_statistics

Conversation

@ben-schwen

Copy link
Copy Markdown
Member

Closes #4677

Not happy that we always call the merge arguments x and i now, even for merge(x,y), but evaluating names of passed arguments seemed overkill.

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
  • HEAD=merge_statistics much slower for as.data.table.array improved in #7019
  • HEAD=merge_statistics much slower for transform improved in #5493
    Comparison Plot

Generated via commit ea5741b

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 37 seconds
Installing different package versions 12 minutes and 18 seconds
Running and plotting the test cases 6 minutes and 48 seconds

@codecov

codecov Bot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (895067d) to head (ea5741b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7566   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          88       88           
  Lines       17266    17289   +23     
=======================================
+ Hits        17097    17120   +23     
  Misses        169      169           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
ben-schwen requested a review from jangorecki July 25, 2026 12:19

@jangorecki jangorecki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afair we have anti join in mergelist, should that be plugged into using this one now?
Uh no, this is only for verbose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

output from merge

2 participants