Preserve review databases across legacy version relabeling - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordAI 0.1.2 opens SQLite with schema version 3 and no downgrade callback. With the pinned sqflite implementation, it can lower a version-4 database's version number while leaving the fingerprint column intact. A subsequent upgrade would try to add the same column and fail.
Recognize the existing nullable TEXT column during migration, preserving its values and learning progress. Reject incompatible column shapes instead of silently marking them upgraded. Explicitly reject databases from future app versions without lowering their version or deleting data. This prepares the same unreleased 0.1.3+4 build.
Real file-backed tests exercise version 4 → legacy version-3 open → version 4, legacy NULL snapshots, preservation of completed attempts, conflicting column shapes, and rejection of a future schema. Focused repository tests and analysis passed locally; CI validates both supported Flutter versions and builds the debug APK.