Conversation
Keep release package filenames stable across tagged builds by using the package version as the distribution name. This preserves the documented release download convention and avoids breaking automation that derives URLs from the version tag.\n\nFixes RavenProject#1207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release packaging currently appends the short HEAD hash to non-release artifact names, producing names such as
raven-4.6.1-7864c39c2-x86_64-linux-gnu.tar.gzand breaking automation that derives downloads from the version tag.Change
Use
raven-${VERSION}as the distribution name for every packaging run. This matches the stable tagged-release naming convention and removes the unused short-hash calculation.Test plan
bash -n .github/scripts/06-package.shPACKAGE_VERSION=4.8.0header: verifiedDISTNAME: raven-4.8.0and no hash suffix. The harness used an unsupported OS only to stop before build commands; the naming logic executed.git diff --checkRisk
Packaging filename convention only; no consensus, runtime, wallet, signing, or release publication changes.
Fixes #1207