Conversation
Declare the restricted-asset clear handlers as Qt slots so the existing button connections resolve through the meta-object system. Refs RavenProject#968
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #968 reports Qt connection warnings when opening Restricted Assets:
No such slot AssignQualifier::clear()No such slot FreezeAddress::clear()Both widgets connect their
buttonClearsignals using the string-based QtSLOT(clear())syntax, butclear()was declared as a regular public method rather than a meta-object slot.Change
Declare
AssignQualifier::clear()andFreezeAddress::clear()inpublic Q_SLOTS. The existing connections and clear implementations remain unchanged.Test plan
git diff --checkvoid clear();directly underpublic Q_SLOTS:.buttonClearconnections useSLOT(clear()).The checkout is unconfigured and Qt's
mocexecutable is not installed on this ARM64 host, so no generated-meta-object or full Qt build was run. The authorized PC should run the Qt build/test gate.Fixes #968