Skip to content

GUI: Raise recommended confirmations #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tabakkui wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −2
Open

GUI: Raise recommended confirmations #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/qt/test/wallettests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "qt/sendcoinsdialog.h"
#include "qt/sendcoinsentry.h"
#include "qt/transactiontablemodel.h"
#include "qt/transactionrecord.h"
#include "qt/transactionview.h"
#include "qt/walletmodel.h"
#include "test/test_raven.h"
Expand Down Expand Up @@ -149,6 +150,8 @@ void BumpFee(TransactionView& view, const uint256& txid, bool expectDisabled, st
// src/qt/test/test_raven-qt -platform cocoa # macOS
void TestGUI()
{
QCOMPARE(TransactionRecord::RecommendedNumConfirmations, 60);

// Set up wallet and chain with 105 blocks (5 mature blocks for spending).
TestChain100Setup test;
for (int i = 0; i < 5; ++i) {
Expand Down
4 changes: 2 additions & 2 deletions src/qt/transactionrecord.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class TransactionStatus
{ }

enum Status {
Confirmed, /**< Have 6 or more confirmations (normal tx) or fully mature (mined tx) **/
Confirmed, /**< Have 60 or more confirmations (normal tx) or fully mature (mined tx) **/
/// Normal (sent/received) transactions
OpenUntilDate, /**< Transaction not yet final, waiting for date */
OpenUntilBlock, /**< Transaction not yet final, waiting for block */
Expand Down Expand Up @@ -85,7 +85,7 @@ class TransactionRecord
};

/** Number of confirmation recommended for accepting a transaction */
static const int RecommendedNumConfirmations = 6;
static const int RecommendedNumConfirmations = 60;

TransactionRecord():
hash(), time(0), type(Other), address(""), debit(0), credit(0), assetName("RVN"), units(8), idx(0)
Expand Down