GitHub Actions cleanup: remove GitHub Pages deploy, add lychee link checker - #135
Open
AMD-melliott wants to merge 3 commits into
Open
AMD-melliott wants to merge 3 commits into
AMD-melliott wants to merge 3 commits into
Conversation
Adapts the lychee config/workflow from ~/git/awesome-rocm, scoped to docs/**/*.md and excluding docs/_build. Also excludes account.amd.com (rejects lychee's HTTP/2 requests) and local .html nav targets used by the instinct-design card partials, which only resolve post-Sphinx-build and can't be validated against markdown source. Fixes two stale links surfaced by the initial run: AMDResearch/omnistat was renamed to ROCm/omnistat, and its GitHub Pages docs moved from amdresearch.github.io/omnistat to rocm.github.io/omnistat.
docs/conf.py's DOCS_BASE_URL already defaults to instinct.docs.amd.com, and production docs aren't served from GitHub Pages, so this workflow is dead weight. No other GitHub Pages-specific config exists in the repo (no CNAME, no gh-pages branch refs).
AMD-melliott
requested review from
mbenavidez-amd and
nabotelh-amd
as code owners
September 10, 2026 18:26
lychee-action@v2 pins lychee v0.24.2 by default, which changed
--include-fragments from a bool flag to a string enum
(none|anchor-only|text-only|full). `include_fragments = false` fails
to parse on that version ("wanted string or table"), even though it
parses fine on the older 0.23.0 CLI used to validate this locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/docs.yml ("Deploy Docs to GitHub Pages"), which was used during theme testing..github/workflows/links.yml+lychee.toml, a lychee-based link checker that runs on push/PR to develop/main, weekly, and via manual dispatch. Scoped todocs/**/*.md, excludesdocs/_build.Why combined
Both changes touch
.github/workflows/and are being landed together as a general Actions cleanup rather than as separate PRs.Notes for reviewers
Related
Closes/supersedes the intent of #113 ("Add broken image link checker"), which targeted the old MyST image-tile card syntax removed by the recent instinct-design flavor migration (#133).
Test plan