fix(ocr): make file extension check case-insensitive - #394
Merged
R0Wi merged 3 commits intoAug 25, 2026
Conversation
Contributor
|
Thanks @chnateag! Would you mind adding a unit test testcase for this? |
Contributor
Author
|
Hi @R0Wi , hope it's done properly |
Contributor
|
Easy. Looks good thanks 🙏 Will try to get the CI running again. That's not your fault, I will take care of it and merge afterwards |
R0Wi
self-requested a review
August 25, 2026 04:12
R0Wi
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When processing files with uppercase extensions (e.g.,
.PDF), the strict comparison$originalFileExtension !== self::PDF_FILE_EXTENSIONevaluates totrue. As a result, the application treats the PDF file as a non-PDF file and appends.pdfto the filename, creating unwanted duplicate files likefilename.PDF.pdf.Solution
Used
strtolower()on$originalFileExtensionindetermineNewFilePath()(lib/Service/OcrService.php) to make the extension check case-insensitive.Testing
Tested on a production Nextcloud instance processing files with
.PDFextensions. The OCR process now overwrites the original file directly without creating.PDF.pdfduplicates.