Sloop speedup - #206
Open
dartsushi wants to merge 8 commits into
Open
Conversation
Modify optimize_S to avoid calculating a constant over and over again
I manually put the gradient and removed AD. It is now two times faster
Removed fixed_point_tensor and its export from TNRKit.
Removed tests for fixed-point tensor basis and 4x4 fixed-point tensor basis.
|
|
||
| @test free_energy(data, ising_βc) ≈ f_onsager rtol = 1.0e-5 | ||
|
|
||
| @info "SLoopTNR Ising fixed-point tensor" |
Member
There was a problem hiding this comment.
These tests should probably also get deleted
Codecov Report❌ Patch coverage is
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed a redundant calculation to speed up slooptnr. We no longer need Zygote either