Skip to content

Collect twistdual utility functions - #427

Merged
leburgel merged 4 commits into
QuantumKitHub:mainfrom
Yue-Zhengyuan:twistdual
Sep 4, 2026
Merged

Collect twistdual utility functions#427
leburgel merged 4 commits into
QuantumKitHub:mainfrom
Yue-Zhengyuan:twistdual

Conversation

@Yue-Zhengyuan

Copy link
Copy Markdown
Member

I think there is now a large enough family of twistdual-like functions, and it's time to collect them in one place.

The non-mutating twistdual is no longer implemented with twist! + copy, but directly using twist.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utility/twistdual.jl 62.50% 6 Missing ⚠️
Files with missing lines Coverage Δ
src/PEPSKit.jl 100.00% <ø> (ø)
...hms/contractions/ctmrg/characteristic_equations.jl 92.51% <ø> (+5.38%) ⬆️
src/algorithms/truncation/fullenv_truncation.jl 94.54% <100.00%> (-0.70%) ⬇️
src/utility/util.jl 79.74% <ø> (+3.40%) ⬆️
src/utility/twistdual.jl 62.50% <62.50%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leburgel leburgel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor preference comments, but I think this is great. Especially happy to get rid of the AD hacks.

Comment thread src/utility/twistdual.jl Outdated
Comment thread src/utility/twistdual.jl Outdated
Comment thread src/utility/twistdual.jl Outdated
@leburgel
leburgel merged commit b2e2e3d into QuantumKitHub:main Sep 4, 2026
69 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants