Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3337/head:pr-3337
git checkout pr-3337This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3337/head |
Paillat-dev
left a comment
There was a problem hiding this comment.
Changelog should not be this specific, and should focus on what was fixed/modified and not why & how.
ToothyDev
left a comment
There was a problem hiding this comment.
Not a huge fan of having multiple heterogenous changes in one PR cause it's hard to review buttttt
I'm generally fine with all this, but I disagree with making required and default None-able. I don't see any reason to allow this, since it's converted to its respective boolean default anyway, and never goes out to the API as MISSING or anything.
|
I have pushed the changes; however, according to semver, this is a breaking change. |
| - Fix `option` keyword argument in `Label.set_radio_group` and | ||
| `Label.set_checkbox_group`. |
There was a problem hiding this comment.
I think this is fine to just say more generally that those functions were fixed; a regular user won't know what this means because it's internal code
Like "Fixed Label.set_radio_group and Label.set_checkbox_group to no longer cause TypeErrors when used" or something. But @JustaSqu1d might know better
| default_values: Sequence[SelectDefaultValue | ST] | None = ..., | ||
| ) -> None: ... | ||
|
|
||
| @overload |
There was a problem hiding this comment.
Just checking, what exactly is the purpose of this new overload?
There was a problem hiding this comment.
To allow a non-literal ComponentType in Label.set_select. Without it basedpyright complains:
No overloads for "__init__" match the provided arguments
Argument types: ...
Signed-off-by: Michael <vmphase.dev@gmail.com>
Summary
Label.set_radio_group()option kwarg typo #3331 (option=>optionskwarg)Select.__init__now has an overload accepting a non-literalComponentTypeRadioGroup,CheckboxGroup, andFileUploadnow acceptNoneforrequired(defaults toTrue), andCheckboxacceptsNonefordefault(defaults toFalse). This was earlier stated in class-docstrings, but not implemented.Label.set_selectoverloads now returnSelfinstead ofNone.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.