feat(asap-tools): separate clickhouse ingest and query cpu/memory monitoring in experiment run clickhouse#522
Open
akanksha-akkihal wants to merge 3 commits into
Conversation
…oring Baseline bulk load now runs under a dedicated ingest monitor that writes monitor_output_ingest.json and stops via a stop file, so ingest CPU/memory is not mixed with the query-phase monitor_output.json. Co-authored-by: Cursor <cursoragent@cursor.com>
Match remote_monitor by execution mode and experiment dir, avoid writing null monitor JSON, escalate stuck sampler with kill(), and clarify ingest stop-file semantics. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
milindsrivastava1997
requested changes
Jul 14, 2026
milindsrivastava1997
left a comment
milindsrivastava1997
left a comment
Contributor
There was a problem hiding this comment.
Does experiment_run_e2e.py need any changes? Has that script been run once with the new remote monitor to verify?
| backend_tool: Optional[str] = None, | ||
| timed_duration: Optional[int] = None, | ||
| pre_query_wait_seconds: int = 0, | ||
| monitor_interval_seconds: float = 1.0, |
Contributor
There was a problem hiding this comment.
If this is defined in config.yaml, can we remove the default argument here
| self, | ||
| minimum_experiment_running_time: int, | ||
| polling_interval: int = 10, | ||
| timeout: int = 600, |
Contributor
There was a problem hiding this comment.
do we need this default arg?
|
|
||
|
|
||
| def stop_monitor(monitor, control_pipe, monitor_pipe): | ||
| def stop_monitor(monitor, control_pipe, monitor_pipe, timeout=30): |
Contributor
There was a problem hiding this comment.
do we need this default arg
| backend_protocol: str, | ||
| backend_tool: Optional[str] = None, | ||
| timed_duration: Optional[int] = None, | ||
| pre_query_wait_seconds: int = 0, |
Contributor
There was a problem hiding this comment.
do we need this default arg if the cmd line args already have a default value
| parser.add_argument( | ||
| "--monitor_interval_seconds", | ||
| type=float, | ||
| default=1.0, |
Contributor
There was a problem hiding this comment.
if this is defined in config.yaml, do we need this default arg?
Contributor
|
Comments from CR with Claude: Hard violations
Magic numbers
Implemented but wrong
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experiment_run_clickhouse.baseline/remote_monitor_output/monitor_output_ingest.jsonand stops via a stop file (with kill fallback); query phase still writesmonitor_output.json.flow.steady_state_waitbefore the query client so precompute + query land in one time series (with bare-metal thread attribution).kill(), matchremote_monitor.pyby--execution_mode+ experiment dir, and avoid writingnullmonitor JSON on timeout.