Update Firewall manifest to declare implementsPretest - #1682
Merged
Steve Lee (SteveL-MSFT) merged 1 commit intoAug 20, 2026
Conversation
Steve Lee (SteveL-MSFT)
requested review from
Mikey Lombardi (He/Him) (michaeltlombardi)
and
a lite review from Copilot
August 19, 2026 18:38
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Windows Firewall resource manifest so the engine will not run an engine-side pretest (test) gate before invoking set, ensuring set still runs when unspecifiedRules (a writeOnly input) is present and can cause changes (fixes #1681).
Changes:
- Set
implementsPretest: truein the Windows Firewall resource manifest so configsetisn’t skipped due to the pretest result whenwriteOnlyinputs are involved. - Reformat
invoke_synthetic_test()in the command resource implementation (no functional change observed).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| resources/windows_firewall/windows_firewall.dsc.resource.json | Declares implementsPretest: true for the FirewallRuleList resource set method to prevent engine-side pretest from skipping set. |
| lib/dsc-lib/src/dscresources/command_resource.rs | Formats invoke_synthetic_test() onto multiple lines for readability (behavior unchanged). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mikey Lombardi (He/Him) (michaeltlombardi)
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
implementsPretestso that when thewriteOnlyunspecifiedRulesproperty is used,setis still calledinvoke_synthetic_test()funciton I noticed while exploring different optionsPR Context
Fix #1681