Test worktree guard fix; make sync-wiring test robust to nested make#24
Test worktree guard fix; make sync-wiring test robust to nested make#24jnasbyupgrade wants to merge 2 commits into
Conversation
Add tests/updates for pgxntool commit 864a4f7 (repo-root guard now works in a git worktree via `git rev-parse --git-dir`): - setup.sh / pgxntool-sync.sh / update-setup-files.sh no longer reject a worktree, where `.git` is a file rather than a directory New regression test in update-setup-files.bats: run the script from inside a linked worktree and confirm it gets past the repo-root guard. Also fix the sync-target wiring test: it matched all of `make -n` output, which failed under `make test-all` because the nested make prints "Entering/Leaving directory" bookkeeping. Grep the pgxntool-sync.sh recipe line and match that exactly instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
After merging master, pgxntool-sync.bats carries the exact-match wiring test, which fails under `make test` (bats runs as a child of make, so the nested `make -n` prints "Entering/Leaving directory"). Grep the pgxntool-sync.sh recipe line and match that exactly instead. Same fix as the open fix-38 PR (#24). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…uard # Conflicts: # test/standard/pgxntool-sync.bats
1 participant
Related pgxntool PR: Postgres-Extensions/pgxntool#39
Covers the pgxntool fix for the
.git-in-a-worktree guard (issue #38).update-setup-files.bats): runsupdate-setup-files.shfrom inside a linked git worktree (where.gitis a file) and confirms it gets past the repo-root guard instead of dying with "Not in a git repository."pgxntool-sync.bats): the sync-target test matched all ofmake -noutput, which failed undermake test-allbecause the nested make prints "Entering/Leaving directory" bookkeeping. It now greps thepgxntool-sync.shrecipe line and matches that exactly — still pins the full command, but ignores make's chatter.Full suite green (212/212) on PG 17.
🤖 Generated with Claude Code