Skip to content

[codex] Make Pro guidance metadata-only - #1

Draft
danieliser wants to merge 1 commit into
mainfrom
agent/metadata-only-pro-guidance
Draft

[codex] Make Pro guidance metadata-only#1
danieliser wants to merge 1 commit into
mainfrom
agent/metadata-only-pro-guidance

Conversation

@danieliser

@danieliser danieliser commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

Make the v2 Extension Framework metadata-only for Legacy → Pro guidance. Popup Maker Core becomes the sole renderer and decision-maker.

Why

Framework-owned offers cannot reach sites whose expired legacy extensions never receive another update. Core has WordPress.org reach and now ships a bundled compatibility catalog for those installations.

What changed

  • Remove the ProUpsell controller and all framework-owned notice, plugin-row, script, and notification-panel rendering.
  • Remove the framework decision logic that enabled or suppressed those offers.
  • Add optional local pro_feature metadata registration through Core's catalog filter.
  • Support feature name, priority, historical basenames, license shortnames, classes, and constants.
  • Preserve Core's bundled identifiers when metadata enhances an existing record.
  • Ignore the old pro_upsell configuration in the new framework release.
  • Bump the package to 1.1.0 and document the ownership boundary and metadata format.

The framework makes no remote calls, fetches no offer content or prices, emits no telemetry, and renders no Legacy → Pro UI.

Validation

  • PHP syntax: passed
  • PHPCS: passed for src/Plugin/Core.php
  • Composer validation: structurally valid; strict mode retains the repository's existing warning about declaring a package version
  • git diff --check: passed
  • This repository does not currently include a formal test suite

Coordinated changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant