PSR-41: modernize secrets-init and fix gRPC CVE#3
Open
ibrahimlawal-paystack wants to merge 11 commits into
Open
PSR-41: modernize secrets-init and fix gRPC CVE#3ibrahimlawal-paystack wants to merge 11 commits into
ibrahimlawal-paystack wants to merge 11 commits into
Conversation
Author
|
@reneed-paystack @husayn-paystack @shabih-paystack CI is green on the current head: https://github.com/ibrahimlawal-paystack/secrets-init/actions/runs/29592815600. Could you please review this modernization and gRPC security update? |
ibrahimlawal-paystack
left a comment
Author
There was a problem hiding this comment.
Bot review: One CI coverage regression remains in the lint migration.
| - examples$ | ||
| formatters: | ||
| enable: | ||
| - gci |
There was a problem hiding this comment.
Bot review: These are formatters in golangci-lint v2, but make lint still only runs golangci-lint run; v2 executes formatter checks through golangci-lint fmt. The old config enforced gci/gofmt/goimports during lint, so CI now silently loses that coverage. Please wire the formatter check into CI and make it fail when files would change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterforward to the published0.5.4nested-key behavior.1.26.5, gRPC1.82.1, and current stable direct dependencies.Validation
make platform-buildgo test -race -timeout 60s ./...actionlint -no-color .github/workflows/*.yamlgo mod verifygovulncheck ./...on Darwin and Linux: zero reachable vulnerabilities1.26.5withgoogle.golang.org/grpc v1.82.1Notes
govulncheckreports module-onlyGO-2026-5932for the unimportedx/crypto/openpgppackage; it has no fixed version and is not in the Linux dependency graph.test.yamlworkflow is not registered by the repository.Tracking