Port many PoB2 trader features#9934
Open
vaisest wants to merge 8 commits into
Open
Conversation
vaisest
marked this pull request as draft
July 8, 2026 16:43
vaisest
marked this pull request as ready for review
July 22, 2026 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes #9685
This reworks the mod filtering to use
itemClass.GetModSpawnWeight()which means that there should be fewer impossible mods in searches. PoE1 has a lot of mods so I think this is quite useful as the max filter count is much more relevant. This was mostly done by porting existing PoB2 changes which I believe were made by Quickstick and adding my own spawn weight checking code onto it.I also made implicit mods use the id since it's easily exportable and makes more sense. #9685 was also fixed since it's a tiny pattern change.
This also ports:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot: