Extract parent proxy handlers and simplify parent-member lookup#2384
Open
PJacek wants to merge 2 commits into
Open
Extract parent proxy handlers and simplify parent-member lookup#2384PJacek wants to merge 2 commits into
PJacek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
JIT traces were aborting due to per-instance dynamic metamethods and anonymous closures created for parent lookups and constructor calls.
Example trace aborts:
Changes made:
parentIndexandparentCall._parentand_objectand reuse the extracted handlers instead of creating new anonymous closures per parent.__indexlogic.Impact:
FNEWtrace aborts (verified usingjit.v). While the exact counts vary between runs due to non-deterministic nature of the JIT, I observed fewer abort and more successful traces inCommon.lua.