Make NDC pension growth-rate settings parameters so the system can run - #1190
Open
marcelolafleur wants to merge 2 commits into
Open
Make NDC pension growth-rate settings parameters so the system can run#1190marcelolafleur wants to merge 2 commits into
marcelolafleur wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
+ Coverage 72.66% 72.71% +0.04%
==========================================
Files 22 22
Lines 5726 5725 -1
==========================================
+ Hits 4161 4163 +2
+ Misses 1565 1562 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1169. Follow-up to #1167, which fixed the other two non-US pension systems.
The notional defined contribution pension system crashes as soon as you try to use it. Its growth-rate settings were never added to the parameters file, so the model stops with an error before computing anything. Behind that error sat two smaller bugs of the same kind: the growth-rate functions expect time paths but get single numbers in the steady state, and the benefit formula reads mortality rates from an attribute that only the unit tests ever set.
Changes:
Tested: pension and parameter test suites pass, ruff clean. Bumps to 0.19.0 with a changelog entry.
cc @rickecon @jdebacker