Expose planet production fees in the planet payload - #39
Open
Raukk wants to merge 1 commit into
Open
Conversation
The FIO importer already syncs GamePlanetProductionFee per planet; serialize it on GamePlanetSerializer so clients can read it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PFsCfBfPMjbxDYBoh65xYC
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FIO importer already syncs GamePlanetProductionFee per planet (planet_sync_production_fees), but GamePlanetSerializer doesn't expose it. This adds a nested production_fees field (category, workforce_level, fee_amount, fee_currency), the matching prefetch in queryset_gameplanet(), and an API test.
Related: A change (PR) on PRUNplanner/frontend reads this field to show production fees in the plan overview. It tolerates the field being absent, so merge order doesn't matter.
I'm really out of date with Python so I leaned on AI to make this change. Also, this is like my second opensource PR in a decade, please kindly let me know if I messed something up.