fix: rank imported/same-namespace symbols above non-imported in completion#229
Merged
Conversation
calebdw
force-pushed
the
calebdw/push-kulnruktqovs
branch
from
7219b01 to
959d6c6
Compare
…etion Swap source_tier before origin_tier in the sort_text key for class, function, and constant completions. Previously origin_tier (project > core > vendor) came first, so a non-imported project class could outrank an already-imported vendor class. Now an imported symbol always ranks above a non-imported one regardless of provenance. Affects class_sort_text in class_completion.rs and flat_symbol_sort_text in symbol_ranking.rs.
calebdw
force-pushed
the
calebdw/push-kulnruktqovs
branch
from
959d6c6 to
ad28f07
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap source_tier before origin_tier in the sort_text key for class, function, and constant completions. Previously origin_tier (project > core > vendor) came first, so a non-imported project class could outrank an already-imported vendor class. Now an imported symbol always ranks above a non-imported one regardless of provenance.