prebid: add pubProvidedId delivery of cached EIDs via user-id config - #331
Open
etiennelatendresse-optable wants to merge 1 commit into
Open
etiennelatendresse-optable wants to merge 1 commit into
etiennelatendresse-optable wants to merge 1 commit into
Conversation
etiennelatendresse-optable
force-pushed
the
migrate-pub-provided-id
branch
from
September 2, 2026 17:12
5ef2206 to
749b43b
Compare
4 tasks
etiennelatendresse-optable
force-pushed
the
migrate-pub-provided-id
branch
from
September 3, 2026 14:54
749b43b to
5559fa6
Compare
etiennelatendresse-optable
force-pushed
the
migrate-pub-provided-id
branch
from
September 17, 2026 16:41
e3c6326 to
af9bd75
Compare
etiennelatendresse-optable
force-pushed
the
migrate-pub-provided-id
branch
from
September 17, 2026 17:03
af9bd75 to
374fc62
Compare
mosherBT
reviewed
Sep 22, 2026
| }); | ||
|
|
||
| pbjs.setConfig?.({ userSync: { ...currentUserSync, userIds: updatedUserIds } }); | ||
| if (options.refreshAll) { |
Contributor
There was a problem hiding this comment.
This will happen for every call not once per page load
mosherBT
requested review from
a team,
FranckGarnier and
jplaroche
and removed request for
jmarc101
September 22, 2026 14:42
mosherBT
reviewed
Sep 22, 2026
| function stripSidecars(eid: Eid): Eid { | ||
| const clean: Record<string, unknown> = {}; | ||
| for (const key of Object.keys(eid)) { | ||
| if (!key.startsWith("_")) { |
Contributor
There was a problem hiding this comment.
This will check for _refs which is not true anymore for how we handle those in the cah=che
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pubProvidedIdcould be moved to a reusable function.What Changed
mergeIntoPubProvidedId({ instances, cacheKey, eids })How to Test
Notes
Co-authored-by: Etienne Latendresse etienne.latendresse@optable.co