Skip to content

Remove request URL from error strings - #48

Open
mosherBT wants to merge 1 commit into
masterfrom
sdk-error-url-redaction
Open

mosherBT wants to merge 1 commit into
masterfrom
sdk-error-url-redaction

Conversation

@mosherBT

Copy link
Copy Markdown
Contributor

Why

Error strings echoed the request URL back to the host app. On targeting that URL carries the hashed email and advertising ID, so anything logging the error logs identifiers.

What Changed

  • android_sdk: error message uses response.code(), not $response — whose toString() includes url=
  • android_sdk: read errorBody()?.string(); the old code printed the ResponseBody identity hash
  • android_sdk: dropped the deep link URL from the prefixedIdFromUrl failure log, which wrote oeid to logcat

How to Test

  • ./gradlew test passes

Notes

  • Requires release

@mosherBT mosherBT self-assigned this Sep 22, 2026
@mosherBT
mosherBT marked this pull request as ready for review September 22, 2026 17:59
@mosherBT
mosherBT requested review from a team as code owners September 22, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant