Convert wall reaction parameters in EN_setflowunits - #935
Merged
LRossman merged 1 commit intoAug 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN_setflowunits() updates a project's unit system and already converts
unit-dependent hydraulic data, but wall reaction parameters are currently
left unchanged.
This changes the physical meaning of wall reactions when switching between
US customary and SI flow units. For example, a first-order wall coefficient
of -1 ft/day becomes -1 m/day instead of the equivalent -0.3048 m/day.
This change converts wall reaction parameters whenever the unit system
changes:
Two regression tests cover first-order and zero-order wall reactions. They
verify both the converted coefficient values and preservation of the
resulting water-quality solution across a US-to-SI unit change and back.