ci: run workflows on 19.0-staging-* branches - #376
Merged
Conversation
Security fixes will be validated in batches on staging branches (19.0-staging-*) before merging to 19.0. Without this, PRs retargeted to a staging branch get no CI runs at all.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #376 +/- ##
==========================================
- Coverage 74.28% 67.79% -6.50%
==========================================
Files 372 94 -278
Lines 25385 8312 -17073
==========================================
- Hits 18857 5635 -13222
+ Misses 6528 2677 -3851
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The security-fix campaign (18+ open security PRs) will be merged to
19.0in validated batches via staging branches named19.0-staging-*(e.g.19.0-staging-sec-batch1). PRs are retargeted to the staging branch, reviewed and merged there one at a time, the batch is validated (full CI + upgrade tests + human test), and only then is the staging branch merged into19.0— keeping19.0stable for the deployments that track it directly.All four workflows currently trigger only on
19.0, so a PR targeting a staging branch would get zero checks (green-by-absence). This adds the19.0-staging-*wildcard to thepull_requestandpushfilters of:ci.ymlpre-commit.ymlsecurity.ymlcode-analysis.ymlThe wildcard is permanent infrastructure: future staging campaigns reuse the naming pattern with no further CI changes. (
*in Actions globs doesn't match/, hence a dash-based naming convention.)Notes
ci.ymlalready resolves the PR base dynamically viagithub.base_ref, and no workflow has other hardcoded19.0refs (verified by grep).19.0at cut time.19.0-staging-ci-testbranch, open a scratch PR against it, confirm all four workflows trigger, close and delete.