[FROM-ML] drm: Add passive_vrr properties for passive/desktop VRR - #110
Merged
Conversation
KyleGospo
changed the title
KyleGospo
changed the title
Member
|
Please keep the link. Easiest way is with |
Add the PASSIVE_VRR_DISABLED atomic CRTC property (drm_crtc_state. passive_vrr_disabled) and the immutable passive_vrr_capable connector property, together with drm_connector_attach_passive_vrr_capable_property() and drm_connector_set_passive_vrr_capable_property() helpers. Passive VRR keeps a sink in its variable-refresh state during fixed refresh (desktop) use, avoiding blanking/flicker on VRR entry/exit for HDMI sinks that lack seamless VRR transitions. The property is opt-out (default enabled where the connector advertises passive_vrr_capable); lacking hardware support is not treated as failure. Not useful for DP/eDP where seamless VRR transitions are enforced by the standard. Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com> Signed-off-by: Fangzhi Zuo <Jerry.Zuo@amd.com> Link: https://lore.kernel.org/r/20260901191251.2653684-2-jerry.zuo@amd.com
Wire the passive_vrr DRM properties into amdgpu for HDMI/DP/eDP sinks: - Add dm_connector_state.freesync_on_desktop_capable and copy it in amdgpu_dm_connector_atomic_duplicate_state(). - Attach the passive_vrr_capable connector property alongside vrr_capable for non-MST connectors. - In amdgpu_dm_update_freesync_caps(), record freesync_on_desktop_capable and update the passive_vrr_capable property from freesync_capable. - In amdgpu_dm_get_freesync_config_for_crtc(), drive stream->freesync_on_desktop from the inverse of passive_vrr_disabled when capable, hooking into the existing DC freesync_on_desktop logic that keeps the FreeSync-Active bit set during fixed-refresh (desktop) use. Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com> Signed-off-by: Fangzhi Zuo <Jerry.Zuo@amd.com> Link: https://lore.kernel.org/r/20260901191251.2653684-3-jerry.zuo@amd.com
…S fallback amdgpu_dm_update_freesync_caps() clears freesync_capable for any SIGNAL_TYPE_HDMI_TYPE_A sink that lacks an AMD FreeSync MCCS VCP code. HDMI-Forum VRR (HF-VSDB) sinks advertise VRR without such a VCP code, so the HF-VSDB fallback that set freesync_capable was immediately undone, leaving VRR and passive VRR disabled on those sinks. Skip the MCCS clear when the sink reports HF-VSDB VRR capability, so freesync_capable survives for HDMI-Forum VRR sinks. Signed-off-by: Fangzhi Zuo <Jerry.Zuo@amd.com> Link: https://lore.kernel.org/r/20260901191251.2653684-4-jerry.zuo@amd.com
Member
Author
Should be addressed now, thanks |
pastaq
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.