AD: BEM: Adding quasi-steady outputs Cx, Cy, phi - #3445
Open
ebranlard wants to merge 1 commit into
Open
Conversation
ebranlard
force-pushed
the
f/BEM-qs-out
branch
from
August 27, 2026 15:12
bfe8a72 to
a5c0b89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged
Feature or improvement description
This pull request stores the quasi-steady flow angle phi, together with the projected coefficients
CxandCyused by BEM, and therefore addsBEM_Cx_qs,BEM_Cy_qsand ,BEM_phi_qsto the AeroDyn Nodes outputs.The current output channel
Phiis different fromBEM_phi_qsbecause,BEM_phi_qs, the flow angle from the BEM constraint equation, gets overwritten by one that is consistent with Vx, Vy, a, and a' (stored inPhi). This erasing of the flow angle makes debugging BEM harder.The following were added to the Xlsx outlist parameters file:
Impacted areas of the software
AeroDyn BEMT
Additional context
The "erasing" of the flow angle output occurs in
BEMT_CalcOutput:BEMT_CalcOutput_Inductionsis called, which leads to the constrainedphivalue.SetInputs_for_UA_AllNodes, the functionComputePhiWithInductionis called, which leads to a different phi:phi(i,j) = ComputePhiWithInduction( u%Vx(i,j), u%Vy(i,j), axInduction(i,j), tanInduction(i,j), u%cantAngle(i,j), u%xVelCorr(i,j) )