fix: align Tray with the native Desktop protocol - #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Tray now uses the Desktop protocol that the installed product exposes. It checks protocol version 1, authenticates each command, and requests current status as soon as it connects. Recording and compile events now map to the states that Desktop sends.
The launcher opens the native Desktop app through the platform's installed identity. macOS uses the bundle ID. Windows uses the known installer paths. Linux uses the installed desktop entry or binary. An explicit AppImage path remains available for portable installs.
The lock file also moves
cryptographyfrom 49.0.0 to 50.0.0.Verification
uv run pytest -q: 257 passed, 2 skippeduv run ruff check src tests: passeduv run python scripts/check_source_boundary.py: passeduv build: built the wheel and source archiveuv run python scripts/check_release_consistency.py --require-dist: passedgitleaks git --redact --log-opts="origin/main..HEAD": no leaks foundI also checked the public Desktop 0.15.0 Debian package. It installs
OpenAdapt Desktop.desktopand/usr/bin/openadapt-desktop, which are the Linux identities used here.Review order
Review and merge this PR before the paired Desktop PR. Desktop tests the exact Tray commit
debe280ae7b1bd81d1c353809056599f094b2f64.This PR doesn't publish a package or create a release.