fix: ship the OpenAdapt robot as the macOS app icon and DMG - #155
Merged
Conversation
The v0.15.0 DMG used Tauri's green rounded square with a bar. Finder reads that as a minus. .gitignore dropped src-tauri/icons/*.icns, so the bundle never carried a real icns. Paint the website robot on a full-bleed #0B1220 square. macOS applies the squircle. Brand the 660x400 drag-to-Applications window. Track icon.icns. Do not retag v0.15.0.
Member
Author
|
Merged by an agent session, not the founder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finder on the v0.15.0 DMG shows a green rounded square with a bar. That's Tauri's placeholder, and macOS draws it as a minus.
.gitignorewas droppingsrc-tauri/icons/*.icns, so the bundle never carried a real icns.This copies the website robot (
openadapt-webpublic/apple-touch-icon.pngandpublic/images/favicon.svg) onto a full-bleed#0B1220square. macOS applies the squircle mask. The DMG window is 660x400, ink background, wordmark, "Drag to Applications", and an arrow betweenappPosition(180, 170) andapplicationFolderPosition(480, 170). Version stays 0.15.0.A new
desktop-v*tag after merge is what actually puts a new DMG on GitHub. Do not retagv0.15.0. The file already downloaded will not change.Reviewer checks
src-tauri/icons/icon.pngSHA-256 must not start withbfe0288bd6f672e2883e771ae509769f25e704bb. On this commit it is5e73ac7717650c9aeef7920c3ceaebf58c83c6b4f058573d2a8236e8e2ea9a5d.src-tauri/icons/icon.icnsis tracked (git ls-fileslists it) and listed inbundle.icon.bundle.macOS.dmg.backgroundisdmg/background.png, 660x400.python -m pytest tests/test_bundle_icons.pypasses.python3 scripts/render_bundle_icons.py(Pillow, macOSiconutil).Opened by an agent session, not the founder.