Skip to content

fix(signatures): use data action instead of command_execution (#299)#300

Draft
antoinemzs wants to merge 1 commit into
mainfrom
299/use-data-action
Draft

fix(signatures): use data action instead of command_execution (#299)#300
antoinemzs wants to merge 1 commit into
mainfrom
299/use-data-action

Conversation

@antoinemzs

Copy link
Copy Markdown
Member

Proposed changes

  • Use the correct data action for sending signatures (changed from command_execution)

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@antoinemzs antoinemzs self-assigned this Jun 30, 2026
@antoinemzs antoinemzs added the do not merge Do not merge until this label is removed. label Jun 30, 2026
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jun 30, 2026
@antoinemzs

Copy link
Copy Markdown
Member Author

do not merge until OpenAEV-Platform/openaev#6489 is merged

@Filigran-Automation Filigran-Automation removed the do not merge Do not merge until this label is removed. label Jun 30, 2026
@Filigran-Automation

Copy link
Copy Markdown
Contributor

🤖 [AI-generated]

Hey @antoinemzs! 👋 Thanks a lot for opening PR #300 — really appreciate the fix! 🙏

I just had a quick look and I think the description could be enhanced a little to help reviewers get through it faster. I haven't changed anything in your description — just a gentle suggestion:

Area What could help Suggestion
### Testing Instructions The section still has the placeholder template text ("1. Step-by-step how to test / 2. Environment or config notes") Replace it with the concrete steps to verify the data action is used for signatures (e.g. how you reproduced the previous command_execution behaviour and confirmed the fix)
### Checklist "For bug fix -> I implemented a test that covers the bug" is unchecked If a regression test was added for this fix, tick it — otherwise a quick note on how the change is covered helps reviewers

The Proposed changes and Closes #299 are clear and helpful — thank you! 🙌

💡 If helpful, the contribution conventions / PR template walk through what to include.

No rush at all — thanks again for contributing to OpenAEV! 🚀

Comment thread pyoaev/signatures/types.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(signatures): use correct inject execution action for sending signatures

4 participants