fix(expectations): rename expectation signature field (#294)

[antoinemzs]

Proposed changes

• realign keys between contract and produced trace

Testing Instructions

1. Step-by-step how to test
2. Environment or config notes

Related issues

• Closes fix(scope): expectation signatures structured output is not keyed like configured in contract output element #294

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality
• For bug fix -> I implemented a test that covers the bug

Further comments

[codecov]

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
pyoaev/signatures/models.py	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   73.58%   79.81%   +6.22%     
==========================================
  Files          54       57       +3     
  Lines        2404     2561     +157     
==========================================
+ Hits         1769     2044     +275     
+ Misses        635      517     -118     

Files with missing lines	Coverage Δ
pyoaev/apis/signature.py	91.81% <100.00%> (ø)
pyoaev/signatures/signature_manager.py	72.72% <100.00%> (ø)
pyoaev/signatures/types.py	100.00% <100.00%> (ø)
pyoaev/signatures/models.py	91.06% <91.66%> (+0.05%)	⬆️

... and 14 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Filigran-Automation]

🤖 [AI-generated]

Hey @antoinemzs! 👋 Thanks a lot for opening PR #293 — really appreciate the contribution! 🙏

I just had a quick look and I think the description could be enhanced a little to help reviewers get through it faster. I haven't changed anything in your description — just a gentle, optional suggestion:

Area	What could help	Suggestion
### Proposed changes	The two bullets are still empty	Briefly note what the field was renamed from → to (across pyoaev/apis/signature.py, pyoaev/signatures/models.py, signature_manager.py) and why — e.g. any compatibility/breaking impact for client consumers
### Testing Instructions	Still the template placeholder	Add the concrete steps to verify (e.g. run the test/signatures/... feature & unit tests, expected outcome)
### Related issues	Closes #ISSUE-NUMBER placeholder	Link the tracking issue with a closing keyword, e.g. Closes #123 — every PR should be linked to an issue, and the title is expected to end with the (#issue) reference

💡 If helpful, the contribution conventions / PR template walk through what to include.

No rush at all — thanks again for contributing to the project! 🚀

[guzmud]

LGTM 👍 (we just need to replace the command_execution at some point)

[Copilot]

Pull request overview

This PR aims to realign the “expectation signature(s)” structured output keys and execution metadata to match the expected contract/wire format, and updates the signature transmission and post-execution update tests accordingly.

Changes:

• Renames the structured output JSON key from signatures to expectation_signatures across signature building, transmission, envelope chunking, and tests.
• Introduces an ExecutionStatus enum and updates post-execution logic/tests to use enum-driven status strings (e.g., EXECUTED, ERROR, TIMEOUT).
• Updates BDD feature/constraint expectations and related step implementations to reflect the new status/action strings.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/signatures/test_signature_manager_transmission.py	Updates transmission tests to use expectation_signatures and enum execution status.
test/signatures/test_signature_manager_post_execution.py	Updates post-execution tests to assert enum-based execution status values.
test/signatures/features/signature_manager_post_execution.feature	Updates feature expectations for execution status/action to new values.
test/signatures/constraints/signature_manager_post_execution_constraints.feature	Updates constraint scenarios to expect enum-based status strings.
pyoaev/signatures/types.py	Adds ExecutionStatus enum values used by execution detail updates and tests.
pyoaev/signatures/signature_manager.py	Updates signature output structure creation to emit expectation_signatures.
pyoaev/signatures/models.py	Renames output structure field, changes ExecutionDetails.execution_status typing, and updates post-execution status mapping.
pyoaev/apis/signature.py	Updates payload parsing/envelope chunking to read/write expectation_signatures.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.