ctrace initial development - #2548
Conversation
Test Results 4 files - 37 8 suites - 117 8s ⏱️ - 18m 23s Results for commit af656ec. ± Comparison against base commit fba299a. This pull request removes 882 tests.♻️ This comment has been updated with latest results. |
jreineckearm
left a comment
There was a problem hiding this comment.
Just had a look at the first few files in this PR (the GH workflows). You may want to review those first. I think some of them will impact more than ctrace.
Also, why do you make workflows sensitive to changes in subfolders of external? I don't think GitHub actions are clever enough to detect changes in git submodules. But I might be wrong.
edriouk
left a comment
There was a problem hiding this comment.
all ctrace* project files must have Header File directory => changes in CMakeLists.txt files are required:
SET(PROJMGR_HEADER_FILES ...
edriouk
left a comment
There was a problem hiding this comment.
All classes and their public methods must have DOXYGEN-style comments
|
test/data folders contain *.license files. They probably should be removed. |
Simplify diagnostics and trace metadata handling, remove stale APIs and schema entries, and align output selection behavior. Refresh platform test support, documentation, and release-facing validation.
jreineckearm
left a comment
There was a problem hiding this comment.
Light-weight review of all but the ctrace test subfolder. See comments.
Overall massive improvement since initial push. No more systematic flaws like the LCOV excludes or use of #pragma once.
jreineckearm
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
Feedback has been incorporated as requested.
More fixes and enhancements in smaller increments from here on.
edriouk
left a comment
There was a problem hiding this comment.
LGTM
I have pulled all recent changes, build and run unit tests on Windows locally.
All succeeded
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
==========================================
+ Coverage 68.34% 72.13% +3.79%
==========================================
Files 141 185 +44
Lines 26511 30117 +3606
Branches 16022 17769 +1747
==========================================
+ Hits 18119 21725 +3606
+ Misses 6090 6087 -3
- Partials 2302 2305 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Implements
ctraceimplementation for decoding SWO streams containing ITM and DWT data.Limitations
Checklist