Skip to content

fix: require iOS 12 for OneSignal iOS 5.6.0 #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 2 commits into from
Sep 9, 2026
Merged

fix: require iOS 12 for OneSignal iOS 5.6.0 #896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c096a0
fix: raise minimum iOS version to 12
fadi-george Sep 8, 2026
013b258
ci(codeql): remove pull_request trigger
fadi-george Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ concurrency:
on:
push:
branches: ["main"]
pull_request:
branches: ["main"]
schedule:
- cron: "32 13 * * 0"

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ And via many additional platforms. [Check them all out](https://documentation.on
- iOS Builds: CocoaPods 1.11.3 or newer
- In order to test push notifications you will need
- An Android 7 or newer device or emulator with "Google Play Store (Services)" installed
- An iOS 11 or newer device (iPhone, iPad, or iPod Touch)
- An iOS 12 or newer device (iPhone, iPad, or iPod Touch)

### Push Notification Credentials
You must generate the appropriate credentials for the platform(s) you are releasing on:
Expand Down
2 changes: 1 addition & 1 deletion com.onesignal.unity.ios/Editor/BuildPostProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ private void AddNotificationServiceExtension()

// Makes it so that the extension target is Universal (not just iPhone)
_project.SetBuildProperty(extensionGuid, "TARGETED_DEVICE_FAMILY", "1,2");
_project.SetBuildProperty(extensionGuid, "IPHONEOS_DEPLOYMENT_TARGET", "11.0");
_project.SetBuildProperty(extensionGuid, "IPHONEOS_DEPLOYMENT_TARGET", "12.0");
_project.SetBuildProperty(extensionGuid, "SWIFT_VERSION", "5.0");
_project.SetBuildProperty(
extensionGuid,
Expand Down
2 changes: 1 addition & 1 deletion examples/demo/Assets/OneSignal/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ And via many additional platforms. [Check them all out](https://documentation.on
- iOS Builds: CocoaPods 1.11.3 or newer
- In order to test push notifications you will need
- An Android 7 or newer device or emulator with "Google Play Store (Services)" installed
- An iOS 11 or newer device (iPhone, iPad, or iPod Touch)
- An iOS 12 or newer device (iPhone, iPad, or iPod Touch)

### Push Notification Credentials
You must generate the appropriate credentials for the platform(s) you are releasing on:
Expand Down