Conversation
Treat truncated nonzero range responses as network errors when the advertised remote file size indicates more data should be available. This prevents short HTTP bodies from being cached or copied as valid chunk data.
Add a direct network file test for truncated range responses basic failure path so unexpected successful creation does not leak the PJ/context during test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking the patch as provided to push it through our CI machinery, but it needs a thorough review too. It's a little verbose, but it makes sense to guard the subtraction so it doesn't go OOR.
docs/source/*.rstfor new API