refactor(lints): adopt #[expect] and fix crypto/frost lint inheritance - #675
Open
varex83agent wants to merge 1 commit into
Open
refactor(lints): adopt #[expect] and fix crypto/frost lint inheritance#675varex83agent wants to merge 1 commit into
varex83agent wants to merge 1 commit into
Conversation
Closes #609. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #609.
Converted ~76 justified
#[allow]/#![allow]suppressions in hand-written code to#[expect(..., reason = "...")](0 -> 84#[expect]attrs; non-generated bare#[allow]count dropped from ~92 to 16, each now carrying a reason). Removed several stale suppressions whose wiring has landed (e.g.dead_codeontracker/inclusion.rs,tracker/reason.rs,validatorapifields,dkg signing, and a now-transformedtoo_many_argumentsonBeaconMock::new). Cases where#[expect]would be unfulfilled on some target (e.g.async_fn_in_trait, test/examplemissing_docs,deprecated, test-onlydead_code) are kept as#[allow]with an explanatory reason comment. Generated code (proto includes,build-proto,eth2apibindings) andtbls::math'sunsafe_codeopt-in were left untouched.Fixed the crypto/frost
[lints]inheritance drift: both re-listed the clippy set by hand and missed the workspace-deniedredundant_test_prefix. Cargo does not allow[lints] workspace = truecombined with a per-lint override, and both crates must relaxunsafe_codefor the blst C bindings, so the lint set is now listed explicitly, completed withredundant_test_prefix, and documented as needing to stay in sync with[workspace.lints].Gates:
cargo +nightly fmt --all --check,cargo clippy --workspace --all-targets --all-features -- -D warnings, andcargo test --workspace --all-featuresall pass.Co-Authored-By: Bohdan Ohorodnii 35969035+varex83@users.noreply.github.com