Change: Merge Limits table's depth column into the mix column - #204
Merged
Conversation
The Limits table listed a 'Depth' per mix that could be read as a maximum operating depth, but it actually showed the deepest point that mix was used during this specific plan, which can be shallower than its real MOD. This commit removes the depth column and adds the depth to the mix ('mix @ depth') cell so the relationship reads hopefully unambiguously.
Fixes: #199
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 70.48% 70.44% -0.05%
==========================================
Files 142 143 +1
Lines 8143 8154 +11
Branches 1040 1042 +2
==========================================
+ Hits 5740 5744 +4
- Misses 1886 1891 +5
- Partials 517 519 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Limits table listed a 'Depth' per mix that could be read as a maximum operating depth, but it actually showed the deepest point that mix was used during this specific plan, which can be shallower than its real MOD. This commit removes the depth column and adds the depth to the mix ('mix @ depth') cell so the relationship reads hopefully unambiguously.
Fixes: #199