spdmd: add the support for platform composite attestation - #2
Open
helloxiling wants to merge 2 commits into
Open
spdmd: add the support for platform composite attestation #2helloxiling wants to merge 2 commits into
helloxiling wants to merge 2 commits into
Conversation
helloxiling
force-pushed
the
xsun/spdmd-composite-attestation-support
branch
6 times, most recently
from
July 3, 2026 18:52
69215c9 to
7a8f8fb
Compare
helloxiling
force-pushed
the
xsun/spdmd-composite-attestation-support
branch
from
July 4, 2026 06:27
7a8f8fb to
ce5f728
Compare
ratagupt
reviewed
Aug 11, 2026
ratagupt
left a comment
There was a problem hiding this comment.
Xiling , I really like the code. It is written very neatly and is well documented. I have completed my first pass and only have a few comments so far. I will do another round of review as well.
Author
@ratagupt Ratan, appreciate for your detailed review! Those comments are very helpful for the code enhancement. The latest patch addressed them. Please let me know if there are any questions or concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation
spdmdandbmcwebactiveGET /redfish/v1/ComponentIntegrity/exposed one synthetic responderPOST /redfish/v1/ComponentIntegrity/Actions/Oem/Oem.GetCompositeEATBundlereturned202GET /redfish/v1/ComponentIntegrity/CompositeEATBundle/returnedStatus: Ready