Skip to content

spdmd: add the support for platform composite attestation - #2

Open
helloxiling wants to merge 2 commits into
NVIDIA:developfrom
helloxiling:xsun/spdmd-composite-attestation-support
Open

spdmd: add the support for platform composite attestation #2
helloxiling wants to merge 2 commits into
NVIDIA:developfrom
helloxiling:xsun/spdmd-composite-attestation-support

Conversation

@helloxiling

Copy link
Copy Markdown
  • Add the composite attestation core for building detached Claims-Sets, submodule digests, and tag-602 Detached EAT bundles from collected SPDM evidence.
  • Wire the optional D-Bus composite bundle interface behind the composite-attestation Meson feature.
  • Define the vendor-neutral Lead Attester interface, and limit the upstream concrete backend to the software mock used for development and test.

Validation

  • Standalone composite/mock attestation tests pass: 11 suites / 64 tests.
  • QEMU emulation smoke test completed with the local test patch:
    • spdmd and bmcweb active
    • GET /redfish/v1/ComponentIntegrity/ exposed one synthetic responder
    • POST /redfish/v1/ComponentIntegrity/Actions/Oem/Oem.GetCompositeEATBundle returned 202
    • GET /redfish/v1/ComponentIntegrity/CompositeEATBundle/ returned Status: Ready
    • Generated bundle verified successfully: COSE_Sign1 ES384 signature, nonce/UEID/profile/submods/measurements, and submodule digest recomputation.
  • E2E hardware validation with Microsoft OpenBMC and a real RoT acting as the lead attester.

@helloxiling
helloxiling force-pushed the xsun/spdmd-composite-attestation-support branch 6 times, most recently from 69215c9 to 7a8f8fb Compare July 3, 2026 18:52
@helloxiling
helloxiling force-pushed the xsun/spdmd-composite-attestation-support branch from 7a8f8fb to ce5f728 Compare July 4, 2026 06:27

@ratagupt ratagupt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xiling , I really like the code. It is written very neatly and is well documented. I have completed my first pass and only have a few comments so far. I will do another round of review as well.

Comment thread spdmd/composite/composite_orchestrator.cpp
Comment thread spdmd/composite/collection_plan.cpp Outdated
Comment thread spdmd/dbus_impl_composite.cpp Outdated
Comment thread libspdmcpp/connection.cpp Outdated
Comment thread libspdmcpp/connection.cpp Outdated
Comment thread spdmd/composite/pem.cpp Outdated
Comment thread spdmd/composite/pem.cpp Outdated
Comment thread spdmd/composite/submodule_digest.cpp Outdated
Comment thread spdmd/composite/types.hpp
Comment thread spdmd/composite/types.hpp Outdated
@helloxiling

Copy link
Copy Markdown
Author

Xiling , I really like the code. It is written very neatly and is well documented. I have completed my first pass and only have a few comments so far. I will do another round of review as well.

@ratagupt Ratan, appreciate for your detailed review! Those comments are very helpful for the code enhancement. The latest patch addressed them. Please let me know if there are any questions or concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants