fix(docs-version-sync): use the .git marker for the repo root - #550
fix(docs-version-sync): use the .git marker for the repo root#550mesutoezdil wants to merge 10 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRepository guidance now uses nested ChangesRepository-root resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
59f0ad5 to
7b812e7
Compare
d60368f to
61ac660
Compare
findRepoRoot looked for imports.yaml, which this repository does not use, so `go run -C tools/docs-version-sync . --target main` failed with "imports.yaml not found". Resolve the root from the .git marker instead and drop the imports.yaml references from the root AGENTS.md. Closes NVIDIA#549 Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
61ac660 to
f1805d0
Compare
TL;DR
go run -C tools/docs-version-sync . --target main, the command indocs/AGENTS.md, failed withimports.yaml not found.findRepoRootlooked forimports.yaml, which this repository does not use. It now resolves the root from the.gitmarker, and theimports.yamlreferences are removed from the rootAGENTS.md.QA
go test ./...intools/docs-version-syncpasses, includingTestFindRepoRootcovering.gitas a directory,.gitas a worktree file, and the not-found case. Verifiedgo run -C tools/docs-version-sync . --target mainnow runs from a nested directory.Issues
Closes #549
Summary by CodeRabbit
Bug Fixes
Tests
Documentation