Conversation
Signed-off-by: Arash Javanmardi <arash@javanmardi.info>
|
Thanks for the contribution. We will review this PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When config-manager selects an explicit default that does not exist, its error currently omits the profile name (
specified config does not exist). Report the requested default name and add regression coverage for missing/existing defaults and explicit node selections, preserving selection precedence and failure behavior.Checklist
make lint)make test)make check-modules)make check-third-party-notices)Testing
TestUpdateConfigNamefails on unchanged upstream only for the missing-default diagnostic; its four control cases pass.go test ./cmd/config-manager -count=1 -vpasses after the fix.make fmt,make check(0 lint issues), andmake testpass with Go 1.27.1 on Linux ARM64.make testalso builds all packages and four commands.make check-modulesandmake check-third-party-noticespass; notices were regenerated for Linux AMD64 and ARM64.No Kubernetes/GPU end-to-end tests were run. Module and third-party notice regeneration checks also pass on this commit, with no file differences. The module check passed after retrying transient dependency-download EOF failures. The build emits deprecation warnings from vendored NVML C bindings.