Restore clock-event enum coverage with older bindings - #2672
Open
rwgk wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mdboom, could you please advise on the intended long-term solution? Given the compatibility matrix we currently run, the narrow dynamic allowance seems appropriate, but I do not want to undo the earlier removal (see History) without understanding its intent.
Summary
Restore a narrowly scoped compatibility allowance in
test_enum_coverage.pyforClocksEventReasons.BOARD_LIMITandClocksEventReasons.RELIABILITYwhen the installedcuda.bindingsversion predates the corresponding NVML enum names.The allowance is computed dynamically. When the binding names exist, the set is empty and the ordinary full-coverage check still applies. This changes only the coverage test; it does not change runtime behavior.
Why this is needed
This surfaced while validating #2641. That branch exposes the two newer
cuda.coreclock-event members, while its compatibility matrix also tests against older CUDA 12.9 and 13.3cuda.bindingspackages. All 11 failing Linux ARM64 jobs reached the same enum-coverage case: the wrapper hadBOARD_LIMITandRELIABILITY, but those older bindings did not yet haveEVENT_REASON_BOARD_LIMITandEVENT_REASON_RELIABILITY.The production mapping intentionally supports this package-version combination by using the stable numeric NVML values when the names are absent. The coverage test's member-count check did not model that exception and therefore rejected a combination that the runtime mapping handles deliberately. Commit df5356d on #2641 restored this dynamic allowance so the older-bindings rows could continue checking every member they actually provide.
History
The history is less straightforward than the resulting change:
Fix enum handling) before PR 2437 was merged.cuda.corewrapper does not yet expose.