feat(cuda.core): add cluster scheduling policy to LaunchConfig - #2668
Closed
atiaomar1978-hub wants to merge 3 commits into
Closed
feat(cuda.core): add cluster scheduling policy to LaunchConfig#2668atiaomar1978-hub wants to merge 3 commits into
atiaomar1978-hub wants to merge 3 commits into
Conversation
Expose CU_LAUNCH_ATTRIBUTE_CLUSTER_SCHEDULING_POLICY_PREFERENCE on LaunchConfig via ClusterSchedulingPolicyType, with validation, CC >= 9.0 gating, and tests mapping to the native launch attribute. Closes NVIDIA#2629 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
github-actions
Bot
added
the
cuda.core
3 tasks
Assert LaunchConfig emits both CU_LAUNCH_ATTRIBUTE_CLUSTER_DIMENSION and CU_LAUNCH_ATTRIBUTE_CLUSTER_SCHEDULING_POLICY_PREFERENCE when set. Co-authored-by: Cursor <cursoragent@cursor.com>
Use init_cuda with an inline noop kernel so test_launcher.py does not depend on the get_saxpy_kernel_cubin fixture from test_module.py. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks for the contribution! Please wait to be assigned to the related issue before opening a PR. That helps us avoid duplicate work and keep review capacity manageable when several PRs land at once. Please follow our Contributing Guidelines: comment on the issue to express interest, wait for a maintainer to assign it to you, then start the implementation and open the PR. I'm closing this PR for now so we can focus review time on your other open PRs. Feel free to reopen (or open a new PR) once you're assigned on the issue. |
Contributor
|
Closing for now pending issue assignment; see comment above. |
Contributor
Author
|
Okay understood @lijinf2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2629
Add
cluster_scheduling_policy_preferencetoLaunchConfig, mapping toCU_LAUNCH_ATTRIBUTE_CLUSTER_SCHEDULING_POLICY_PREFERENCEvia a newClusterSchedulingPolicyTypeenum (DEFAULT,SPREAD,LOAD_BALANCING).Unlike stream synchronization policy (#2628), cluster scheduling policy is
documented as valid for graph nodes and kernel launches, so
LaunchConfigisthe correct surface.
Checklist
Test plan
cluster=(2,1,1)andLOAD_BALANCINGon Hopper+