Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Expose atomic and sort histograms through the common and Numba APIs. Preserve samples, infer fixed payload shapes, and return independent counter payloads with zero padding beyond the requested bin count. Keep accumulation explicit by adding fresh per-bin results. Support caller-provided scratch without retaining a histogram parent object. Signed-off-by: Trent Nelson <trent@trent.me>
tpn
force-pushed
the
codex/cuda-coop-numba-histogram
branch
from
September 20, 2026 02:56
26a2856 to
8d2299b
Compare
tpn
force-pushed
the
codex/cuda-coop-numba-neighbors
branch
from
September 20, 2026 02:56
21e2b3e to
494ff3b
Compare
Contributor
Author
|
/ok to test 8d2299b |
Contributor
🥳 CI Workflow Results🟩 Finished in 29m 29s: Pass: 100%/8 | Total: 1h 13m | Max: 23m 39sSee results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this is needed
Block-local counting needs a histogram primitive that fits the group-first
API. Add
histogramto the common API andcuda.coop.numba_mlir, backed byCUB's atomic and sort algorithms.
Each call returns fresh striped counters and preserves its samples. Counter
dtype and per-thread output extent are independent of the sample payload.
Slots beyond the requested bin count contain zero. Every sample must be a
valid bin index; there is no input
valid_itemsparameter. Qualified callsalso accept a scalar or fixed local array.
Repeated tiles accumulate by adding returned counters into an ordinary
per-thread payload. No persistent Histogram object or parent/child lifecycle
is introduced. Caller-provided
TempStoragecontrols scratch reuse only.Stacked after #11516. Documentation and
the tested accumulation example are in the final docs PR #11320.
Validation
Fresh installed-wheel checks at
8d2299b79468:Wheel validation and source, installed-package, and bundled-header comparisons passed.
Remote CI passed at
8d2299b79468: GitHub Actions run. All exact-head checks and statuses, including pre-commit, are successful or conditionally skipped.