Skip to content

test(breakfix): require retirement notice evidence (BFX02-02) - #593

Draft
osu wants to merge 1 commit into
NVIDIA:mainfrom
osu:issue-212-gb300-direct
Draft

test(breakfix): require retirement notice evidence (BFX02-02)#593
osu wants to merge 1 commit into
NVIDIA:mainfrom
osu:issue-212-gb300-direct

Conversation

@osu

@osu osu commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

Harden BFX02-02 so generic lifecycle records cannot be treated as retirement-notice evidence.

A PASS requires:

  • provider-origin evidence
  • an explicit instance, machine, node, or rack target
  • a retirement-specific notice type
  • a timezone-aware scheduled retirement timestamp

Generic maintenance, drain, scheduled, closed, down, or self-reported records do not pass.

Validation

  • focused break-fix tests passed
  • full unit and demo suites passed
  • suite wiring, formatting, and pre-commit checks passed
  • read-only provider validation found no authoritative retirement notice, so the live result remains SKIP/unproven rather than a false PASS

Part of #212

Signed-off-by: Hasan Khan <hasank@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dd6433bb-b8a4-43e4-9164-6f3487ed321c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@osu

osu commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

/ok to test 661f442

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-08-21 18:44:22 UTC | Commit: 661f442

@osu osu changed the title fix(breakfix): require retirement notice evidence test(breakfix): require retirement notice evidence (BFX02-02) Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant