feat(kubernetes): add combined topology config surface#2074
Merged
Conversation
|
Label |
|
🌿 Preview your docs: https://nvidia-preview-pr-2074.docs.buildwithfern.com/openshell |
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
e7e3504 to
1f1aef5
Compare
TaylorMutch
commented
Jun 30, 2026
krishicks
reviewed
Jun 30, 2026
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
krishicks
approved these changes
Jun 30, 2026
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the Kubernetes supervisor topology configuration surface with the existing combined topology as the only supported value. This keeps current sandbox behavior unchanged while creating the config, Helm, and documentation shape needed for future topology work.
Related Issue
References #1973.
References #1827.
References #981.
References #899.
References #1305.
Related PR: #2016.
Changes
SupervisorTopologyto the Kubernetes driver config and CLI/env parsing.supervisor_topologyinto Helm-managedgateway.tomlwith chart tests.supervisor.topologyto Helm values and generated chart README.combinedmode and note that additional topologies are still being designed.Testing
mise run pre-commitpassescargo check -p openshell-driver-kubernetespassescargo test -p openshell-driver-kubernetes --libpassesmise run helm:testpassesChecklist