Skip to content

fix: connectParams unconditionally overwritten after socket/hostname - #7

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:sweep/bugfix-fmpm-f4cdbfd9
Open

fix: connectParams unconditionally overwritten after socket/hostname#7
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:sweep/bugfix-fmpm-f4cdbfd9

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 26, 2026

Copy link
Copy Markdown

Problem

connectParams unconditionally overwritten after socket/hostname setup

Fix

Replace:

    memset(connectParams.addressInfo, 0, sizeof(connectParams.addressInfo));
    if ( strnlen(mUnixSockPath, MAX_PATH_LEN) > 0 )
    {
        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mUnixSockPath);
        connectParams.addressIsUnixSocket = 1;
		connectParams.addressType = NV_FM_API_ADDR_TYPE_UNIX;
    }
    if ( strnlen(mHostname, MAX_PATH_LEN) > 0 )
    {
        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mHostname);
        connectParams.addressIsUnixSocket = 0;
		connectParams.addressType = NV_FM_API_ADDR_TYPE_INET;
    }


    strncpy(connectParams.addressInfo, mHostname, sizeof(mHostname));
    connectParams.addressIsUnixSocket = 0;

with:

    memset(connectParams.addressInfo, 0, sizeof(connectParams.addressInfo));
    if ( strnlen(mUnixSockPath, MAX_PATH_LEN) > 0 )
    {
        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mUnixSockPath);
        connectParams.addressIsUnixSocket = 1;
		connectParams.addressType = NV_FM_API_ADDR_TYPE_UNIX;
    }
    else if ( strnlen(mHostname, MAX_PATH_LEN) > 0 )
    {
        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mHostname);
        connectParams.addressIsUnixSocket = 0;
		connectParams.addressType = NV_FM_API_ADDR_TYPE_INET;
    }

Files changed

  • fmpm.cpp

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review July 26, 2026 21:06
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: sole commit is missing a valid Signed-off-by trailer. It does not meet the sweep requirements (single signed-off commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant