Skip to content

fix: --unix-domain-socket address overwritten by hostname - #12

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/fmpm-unix-domain-socket-address-overwritten
Open

fix: --unix-domain-socket address overwritten by hostname#12
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/fmpm-unix-domain-socket-address-overwritten

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in fmpm.cpp: --unix-domain-socket address overwritten by hostname.

Changes

  • fmpm.cpp: --unix-domain-socket address overwritten by hostname.

Details

--- a/fmpm.cpp
+++ b/fmpm.cpp
@@ -1,16 +1,12 @@
-    if ( strnlen(mUnixSockPath, MAX_PATH_LEN) > 0 )
-    {
-        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mUnixSockPath);
-        connectParams.addressIsUnixSocket = 1;
-		connectParams.addressType = NV_FM_API_ADDR_TYPE_UNIX;
-    }
-    if ( strnlen(mHostname, MAX_PATH_LEN) > 0 )
-    {
-        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mHostname);
-        connectParams.addressIsUnixSocket = 0;
-		connectParams.addressType = NV_FM_API_ADDR_TYPE_INET;
-    }
-
-
-    strncpy(connectParams.addressInfo, mHostname, sizeof(mHostname));
-    connectParams.addressIsUnixSocket = 0;
+    if ( strnlen(mUnixSockPath, MAX_PATH_LEN) > 0 )
+    {
+        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mUnixSockPath);
+        connectParams.addressIsUnixSocket = 1;
+		connectParams.addressType = NV_FM_API_ADDR_TYPE_UNIX;
+    }
+    else if ( strnlen(mHostname, MAX_PATH_LEN) > 0 )
+    {
+        snprintf(connectParams.addressInfo, MAX_PATH_LEN, "%s", mHostname);
+        connectParams.addressIsUnixSocket = 0;
+		connectParams.addressType = NV_FM_API_ADDR_TYPE_INET;
+    }

Tests

Let me know if you want tests added for this fix or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant