Prevent silent integer overflows in arithmetic operators

[rostan-t]

Category:

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description:

Currently, arithmetic operators pull constant integers and 32 bits signed ints. As a result, silent overflows can happen, producing wrong results without any warning nor error.

The Python binding forOpSpec::AddArg is already registered as int64_t:

DALI/dali/python/backend_impl.cc

Line 3414 in 3e40f6d

DALI_OPSPEC_ADDARG(int64_t)

And the argument storage uses int64_t for all integral types anyway:

DALI/dali/pipeline/operator/argument.h

Lines 32 to 37 in 3e40f6d

	template <typename T>
	struct argument_storage {
	using type = std::conditional_t<
	std::is_integral<T>::value || std::is_enum<T>::value,
	int64_t, T>;
	};

So we can pull the integer constants as 64 bit integers and error out if any doesn't fit an int32_t.

Additional information:

This is technically a breaking change for uint32 because it used to work accidentally. For instance types.Constant(2**32-1, dtype=types.UINT32) would previously be truncated and the unsigned cast would turn it back to the right value. This raises an exception with this PR.

Affected modules and functionalities:

Integral constants in arithmetic operators.

Key points relevant for the review:

Tests:

• Existing tests apply
• New tests added
  • Python tests
  • GTests
  • Benchmark
  • Other
• N/A

Checklist

Documentation

• Existing documentation applies
• Documentation updated
  • Docstring
  • Doxygen
  • RST
  • Jupyter
  • Other
• N/A

DALI team only

Requirements

• Implements new requirements
• Affects existing requirements
• N/A

REQ IDs: N/A

JIRA TASK: N/A

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with the intentional signed 32-bit compatibility break clearly enforced and tested.

Summary

• Adds signed 32-bit range validation for arithmetic integer constants.
• Preserves overflow exception typing and contextual error messages.
• Adds Python coverage for values immediately above and below the accepted range.

_{Reviews (1) · Last reviewed commit: "Validate int constant bounds in expressi..."}