Extend static analysis for arithmetic operators

[rostan-t]

Category:

New feature (non-breaking change which adds functionality)

Description:

This extends dynamic mode static analysis to support arithmetic operators.

PR #6475 promotes bools, ints, and floats to constants in arithmetic ops. With this PR, we can limit it to only those that are provably constant.

To prevent a regression on Python 3.10 when a call is on the same line as an arithmetic operation, we also add disambiguation on the bytecode since exact span checking is absent.

Additional information:

Affected modules and functionalities:

Dynamic mode.

Key points relevant for the review:

Commits a677329 to 494d10e belong to #6475.

Tests:

• Existing tests apply: test_arithm_ops.py
• New tests added
  • Python tests
  • GTests
  • Benchmark
  • Other
• N/A

Checklist

Documentation

• Existing documentation applies
• Documentation updated
  • Docstring
  • Doxygen
  • RST
  • Jupyter
  • Other
• N/A

DALI team only

Requirements

• Implements new requirements
• Affects existing requirements
• N/A

REQ IDs: N/A

JIRA TASK: N/A

[rostan-t]

!build

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; no actionable correctness, security, or repository-rule violation remains.

Summary

• Adds Python 3.10 bytecode-based disambiguation for calls, binary operations, and augmented assignments.
• Marks Tensor, Batch, and dynamic math arithmetic helpers as transparent for call-site resolution.
• Separates arithmetic tensor inputs from statically proven integer and floating-point constants.
• Adds explicit int32 range validation and updates native arithmetic schema arguments.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[User arithmetic expression] --> B[Resolve application call site]
  B --> C[Locate call or arithmetic CST node]
  C --> D[Classify each operand]
  D -->|Provably constant| E[Embed int32 or float32 constant]
  D -->|Runtime value| F[Convert to Tensor or retain Batch]
  E --> G[Build arithmetic expression]
  F --> G
  G --> H[Execute dynamic arithmetic operator]

Loading

_{Reviews (3) · Last reviewed commit: "Only promote constants arithmetic ops"}

[dali-automaton]

CI MESSAGE: [66962570]: BUILD STARTED

[rostan-t]

!build

[dali-automaton]

CI MESSAGE: [66975775]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [66975775]: BUILD PASSED

[dali-automaton]

CI MESSAGE: [66962570]: BUILD PASSED

[jantonguirao]

[Minor] This unconditionally converts every scalar argument to a Tensor when there are no Tensor/Batch operands at all — which, per the comment above, is exactly the ndd.math.max(2, 3)-style call this PR's constant-promotion feature is meant to help. After this loop runs, every arg has become a Tensor, so the any(type(arg) in (bool, int, float) ...) check below is always False here and none of these arguments can be promoted to integer_constants/real_constants — the whole point of this PR is bypassed for the pure-scalar call path.

The reason for this branch is presumably .NumInput(1, 64) on the underlying op (verified in arithmetic.cc:146) requiring at least one real tensor input, which tensor_args can't guarantee when it's empty. But that only requires one of the arguments to stay a Tensor, not all of them — e.g. converting just args[0] before running constant classification on the rest would satisfy NumInput(1, 64) while still letting the remaining scalars take the $N path.

[rostan-t]

Fixed